feat: add cache evict status

Signed-off-by: Paul Dittamo <pvdittamo@gmail.com>
flyteorg · Jan 22, 2024 · 674ca18 · 674ca18
1 parent cfc38e4
commit 674ca18
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 0 deletions.
diff --git a/packages/console/src/components/Executions/CacheStatus.tsx b/packages/console/src/components/Executions/CacheStatus.tsx
@@ -1,6 +1,7 @@
 import { SvgIconProps, Tooltip, Typography } from '@material-ui/core';
 import { makeStyles, Theme } from '@material-ui/core/styles';
 import CachedOutlined from '@material-ui/icons/CachedOutlined';
+import DeleteOutlinedIcon from '@material-ui/icons/DeleteOutlined';
 import ErrorOutlined from '@material-ui/icons/ErrorOutlined';
 import InfoOutlined from '@material-ui/icons/InfoOutlined';
 import SmsFailedOutlinedIcon from '@material-ui/icons/SmsFailedOutlined';
@@ -50,6 +51,11 @@ const NodeExecutionCacheStatusIcon: React.ComponentType<
     case CatalogCacheStatus.CACHE_HIT: {
       return <CachedOutlined {...props} ref={ref} data-testid="cache-icon" />;
     }
+    case CatalogCacheStatus.CACHE_EVICTED: {
+      return (
+        <DeleteOutlinedIcon {...props} ref={ref} data-testid="cache-icon" />
+      );
+    }
     case CatalogCacheStatus.CACHE_POPULATED: {
       return (
         <PublishedWithChangesOutlined

diff --git a/packages/console/src/components/Executions/constants.ts b/packages/console/src/components/Executions/constants.ts
@@ -274,6 +274,7 @@ export const cacheStatusMessages: { [k in CatalogCacheStatus]: string } = {
   [CatalogCacheStatus.CACHE_PUT_FAILURE]: t('cachePutFailure'),
   [CatalogCacheStatus.MAP_CACHE]: t('mapCacheMessage'),
   [CatalogCacheStatus.CACHE_SKIPPED]: t('cacheSkippedMessage'),
+  [CatalogCacheStatus.CACHE_EVICTED]: t('cacheEvictedMessage'),
 };
 export const unknownCacheStatusString = t('unknownCacheStatusString');
 export const viewSourceExecutionString = t('viewSourceExecutionString');
diff --git a/packages/console/src/components/Executions/strings.ts b/packages/console/src/components/Executions/strings.ts
@@ -19,6 +19,7 @@ const str = {
   unknown: 'Unknown',
   cacheDisabledMessage: 'Caching was disabled for this execution.',
   cacheHitMessage: 'Output for this execution was read from cache.',
+  cacheEvictedMessage: 'Output for this execution was evicted from cache.',
   cacheLookupFailureMessage: 'Failed to lookup cache information.',
   cacheMissMessage: 'No cached output was found for this execution.',
   cachePopulatedMessage: 'The result of this execution was written to cache.',

diff --git a/packages/console/src/components/Executions/test/CacheStatus.test.tsx b/packages/console/src/components/Executions/test/CacheStatus.test.tsx
@@ -95,6 +95,7 @@ describe('Executions > CacheStatus', () => {
       ${CatalogCacheStatus.CACHE_MISS}           | ${cacheStatusMessages[CatalogCacheStatus.CACHE_MISS]}
       ${CatalogCacheStatus.CACHE_POPULATED}      | ${cacheStatusMessages[CatalogCacheStatus.CACHE_POPULATED]}
       ${CatalogCacheStatus.CACHE_PUT_FAILURE}    | ${cacheStatusMessages[CatalogCacheStatus.CACHE_PUT_FAILURE]}
+      ${CatalogCacheStatus.CACHE_EVICTED}        | ${cacheStatusMessages[CatalogCacheStatus.CACHE_EVICTED]}
     `('for each case', ({ cacheStatus, expected }) => {
       it(`renders correct text ${expected} for status ${cacheStatus}`, async () => {
         const { queryByText } = renderComponent({ cacheStatus });

diff --git a/packages/console/src/components/flytegraph/__stories__/CustomNodes.stories.tsx b/packages/console/src/components/flytegraph/__stories__/CustomNodes.stories.tsx
@@ -69,6 +69,7 @@ const CACHE_STATUSES = [
   { status: CatalogCacheStatus.CACHE_MISS, text: 'cache miss' },
   { status: CatalogCacheStatus.CACHE_POPULATED, text: 'cache populated' },
   { status: CatalogCacheStatus.CACHE_PUT_FAILURE, text: 'cache put failure' },
+  { status: CatalogCacheStatus.CACHE_EVICTED, text: 'cache evicted' },
 ];
 
 stories.add('Task Node by Cache Status', () => (