This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Feature: Switch to non interrupible when using the simplified retry behavior #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dennis Keck <26092524+fellhorn@users.noreply.github.com>
fellhorn
force-pushed
the
feature/interruptible-unified-retries
branch
from
24ea431 to
69976b1
Compare
hamersaw
requested review from
kumare3,
EngHabu and
hamersaw
as code owners
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an extension of #596 this adds the non-interruptible switch logic when using the simplified retry behavior.
Part of the flyteorg/flyte#3902 RFC progress.
Does not have tests yet, only as a discussion point.
Discussion topics:
TL;DR
Switch to non-interruptible machines when exhausting the retry budget for the new simplified retry behavior.
Type
Are all requirements met?
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/