Skip to content

- Enhanced Token Validation Parameter Helpers to allow multiple audie… #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

- Enhanced Token Validation Parameter Helpers to allow multiple audie… #23

wants to merge 1 commit into from

Conversation

oleksandrkyselov
Copy link

…nces.

fmichellonet
fmichellonet requested changes Oct 23, 2022
View reviewed changes
Copy link
Owner

@fmichellonet fmichellonet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your pull request.
I've just added a little modification request

src/AzureFunctions.Extensions.OpenIDConnect/Configuration/TokenValidationParametersHelpers.cs

ValidateIssuer = true,
ValidIssuer = issuer
};
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you mind using your newly added overload?
something like :
return Default(new [] {audience}, issuer);

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing, I'll take a look into it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmichellonet fmichellonet fmichellonet requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oleksandrkyselov @fmichellonet @xInfinitYz