(linkwarden) fix: Configmap helm template fix (SSO), replicas parameter #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The iteration over (...).withIssuers uses the $ context
(Re)introduces the replica parameter since Linkwarden is expected to support multiple replicas when S3 storage is enabled
|
Hey @kehralexander, thank you for your changes! I somehow missed those. My bad for leaving you hanging so long again, I missed the notification 🤦🏼 While I'm still not quite sure about the stability of the change, I guess taking that risk should really be up to the user. I was going to try to get in contact with the Linkwarden maintainer within the next few weeks anyways, so I guess he'll be able to offer some insight on that. I'll be sure to update the doc comments in the I've merged and released your changes! 👍🏼 |
|
@FMJdev Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
I think there's a spot in the configmap template that was overlooked when cherry-picking #4.
I've also added the replica parameter again, as linkwarden should support multiple replicas as outlined in #4 (comment)
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer
Checklist
AUTHORSfilefix(charts/linkwarden): ...)