Enabling prometheus support with service monitors #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohanarora
changed the title
rohanarora
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables Prometheus monitoring support for deployed models by adding the ability to create Kubernetes ServiceMonitor resources. The changes allow users to optionally enable Prometheus metrics collection when deploying models for benchmarking.
- Adds a
prometheus_enabledparameter to the benchmark and deployment functions - Refactors service port configuration to use model-specific methods
- Creates ServiceMonitor resources when Prometheus is enabled
- Updates documentation with Prometheus setup instructions
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| fmperf/utils/Benchmarking.py | Adds prometheus_enabled parameter to run_benchmark function |
| fmperf/ModelSpecs.py | Refactors port configuration and adds ServiceMonitor endpoint methods |
| fmperf/Cluster.py | Removes hardcoded annotations, adds ServiceMonitor creation logic |
| examples/example_vllm.py | Demonstrates prometheus_enabled usage |
| docs/SETUP.md | Adds Prometheus installation and setup instructions |
| helm install prometheus-community/kube-prometheus-stack --create-namespace --namespace monitoring --generate-name | ||
| ``` | ||
| INSTEAD (/OR) |
There was a problem hiding this comment.
The text 'INSTEAD (/OR)' should be formatted consistently with other section headers or as proper documentation text. Consider using '## Alternative Setup' or similar.
Suggested change
| INSTEAD (/OR) | |
| ## Alternative Setup |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.