-
Notifications
You must be signed in to change notification settings - Fork 20
Add Makefile, separate core and development requirements #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR separates core and development dependencies into distinct requirement files, adds a Makefile to automate common project tasks, and updates the CI to install development requirements.
- Split dependencies into
requirements.txt(core) andrequirements-dev.txt(development). - Introduced a
Makefilewith targets for venv creation, formatting, linting, type-checking, testing, and cleanup. - Updated GitHub Actions workflow to install dev dependencies before running tests.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| requirements-dev.txt | Added development tools: black, mypy, pytest, ruff, and wheel |
| Makefile | New Makefile with targets for setup, format, lint, type-check, test, etc. |
| .github/workflows/unittests.yml | Install requirements-dev.txt in CI before running tests |
Comments suppressed due to low confidence (1)
Makefile:59
- The Makefile uses
--strictfor type checking but the PR description mentions default options; please align the description or adjust the flags for consistency.
mypy --strict ./fmperf
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
wangchen615
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
In this PR:
requirements.txtandrequirements-dev.txtMakefilefor performing common tasksI kept
blackas the linter unchanged, but addedruffas a formatter andmypyas a type checker for consistency with Inference Perf (however, they are running with default options here).