Skip to content

Conversation

@namasl
Copy link
Contributor

@namasl namasl commented May 23, 2025

In this PR:

  • Separate core and development requirements into requirements.txt and requirements-dev.txt
  • Create a Makefile for performing common tasks

I kept black as the linter unchanged, but added ruff as a formatter and mypy as a type checker for consistency with Inference Perf (however, they are running with default options here).

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR separates core and development dependencies into distinct requirement files, adds a Makefile to automate common project tasks, and updates the CI to install development requirements.

  • Split dependencies into requirements.txt (core) and requirements-dev.txt (development).
  • Introduced a Makefile with targets for venv creation, formatting, linting, type-checking, testing, and cleanup.
  • Updated GitHub Actions workflow to install dev dependencies before running tests.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
requirements-dev.txt Added development tools: black, mypy, pytest, ruff, and wheel
Makefile New Makefile with targets for setup, format, lint, type-check, test, etc.
.github/workflows/unittests.yml Install requirements-dev.txt in CI before running tests
Comments suppressed due to low confidence (1)

Makefile:59

  • The Makefile uses --strict for type checking but the PR description mentions default options; please align the description or adjust the flags for consistency.
mypy --strict ./fmperf

wangchen615 and others added 2 commits June 4, 2025 14:12
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Contributor

@wangchen615 wangchen615 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@wangchen615 wangchen615 merged commit 6dc64c9 into fmperf-project:main Jul 31, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants