request confirmed mailer #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor mailers to ensure confirmation without approval gets to users added confirmation mailer added denied mailer
beingmattlevy
added
confusing-please-revise
kigster
reviewed
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an event is created without needing approval for ticket requests users are sent emails saying the ticket request is being approved and an email confirming will be sent out with payment instructions, etc... This is causing confusion. Need to create a new mailer for the confirmed state.
Unsure how to hook this into the current create / update flow for the ticket request. Unclear how the existing mailers are actually fired. They do not follow existing rails patterns afaik.