Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URLs to use v3 when only v2 endpoint is listed in the catalog #513

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

achevalet
Copy link

It covers the cases where we can authenticate with keystone v3 but the endpoint returned in the catalog is v2
see #492

You guys can probably do something much cleaner as I have poor ruby skills, but it fixes my issue and the tests passed so I'm proposing.. :-)

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jul 20, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jul 20, 2020

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jul 20, 2020

Build succeeded.

It covers the cases where we can authenticate with keystone v3 but the endpoint returned in the catalog is v2
see fog#492
@theopenlab-ci
Copy link

theopenlab-ci bot commented Jul 20, 2020

Build succeeded.

@pdion891
Copy link

tested on an OpenStack not exposing a endpoint for v3 and this fix work fine.

@ShamoX
Copy link
Contributor

ShamoX commented Jan 20, 2022

Just have a little problem with that, it's missing tests implementation of the corrected bug.

I can believe @pdion891 on word but it seems a little risky for the others.

Implemented tests are passing anyway.

@ares
Copy link
Collaborator

ares commented Feb 4, 2022

A test would certainly be good, @achevalet please let us know if you plan to add one.

@pdion891
Copy link

pdion891 commented Feb 4, 2022

Just have a little problem with that, it's missing tests implementation of the corrected bug.

I can believe @pdion891 on word but it seems a little risky for the others.

Implemented tests are passing anyway.

For sure I've only validated the use case that was valid on my side where the /v3 is not exposed.

@achevalet
Copy link
Author

Quite busy, I would be grateful if someone can contribute here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants