Skip to content

(fix) return error from spool foreach #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fogfish merged 1 commit into from
Aug 12, 2025
Merged

(fix) return error from spool foreach #51

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions spool/spool.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ func (spool *Spool) ForEachPath(ctx context.Context, paths []string, f Writer) e
}

// apply spool function over the file
func (spool *Spool) apply(ctx context.Context, path string, f Writer) (err error) {
func (spool *Spool) apply(ctx context.Context, path string, f Writer) (rerr error) {
rfd, err := spool.reader.Open(path)
if err != nil {
return spool.iserr(err)
Expand All @@ -180,9 +180,10 @@ func (spool *Spool) apply(ctx context.Context, path string, f Writer) (err error
return err
}
defer func() {
err = wfd.Close()
err := wfd.Close()
if err != nil {
wfd.Cancel()
rerr = err
}
}()

Expand Down
Loading