Skip to content

EDGCONX-30 dynamic login option #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mis306lu wants to merge 3 commits into
base: master
Choose a base branch
from
Open

EDGCONX-30 dynamic login option #41

mis306lu wants to merge 3 commits into from

Conversation

@mis306lu
Copy link

@mis306lu mis306lu commented Mar 10, 2023

The use case for the 'both' configuration is multiple tenants on one cluster preferring different login strategies.

I tested this on nolana and orchid bugfest using 'both', 'full', 'key' and no configuration (default).

I did consult with Adam after my original pull request. He suggested the 'both' option. It leaves the full and key options as they were so hosts can restrict to one or the other when needed.

@mis306lu mis306lu requested a review from adamdickmeiss March 10, 2023 19:57
@mis306lu
Copy link
Author

mis306lu commented Mar 23, 2023

@dcrossleyau - Do you have any objection to me creating a version with this change? (v1.0.7) thank you!

@dcrossleyau
Copy link
Contributor

dcrossleyau commented Mar 23, 2023

I do not know, sorry.

@mis306lu
Copy link
Author

mis306lu commented Mar 24, 2023

@adamdickmeiss , @wafschneider - any objection to me creating a version with this change? thank you!

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

91.7% 91.7% Coverage
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 1, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
91.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 15, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
91.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

adamdickmeiss
adamdickmeiss requested changes Mar 11, 2025
View reviewed changes
src/main/java/org/folio/edge/connexion/MainVerticle.java
if (loginStrategyType == LoginStrategyType.both) {
if (connexionRequest.getLocalUser() != null && connexionRequest.getLocalUser().strip()
.contains(" ")) {
loginStrategyType = LoginStrategyType.valueOf("full");
Copy link
Contributor

@adamdickmeiss adamdickmeiss Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
loginStrategyType = LoginStrategyType.valueOf("full");
loginStrategyType = LoginStrategyType.full;

src/main/java/org/folio/edge/connexion/MainVerticle.java
.contains(" ")) {
loginStrategyType = LoginStrategyType.valueOf("full");
} else {
loginStrategyType = LoginStrategyType.valueOf("key");
Copy link
Contributor

@adamdickmeiss adamdickmeiss Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
loginStrategyType = LoginStrategyType.valueOf("key");
loginStrategyType = LoginStrategyType.key;

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 12, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
91.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

2 similar comments
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 15, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
91.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 12, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
91.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamdickmeiss adamdickmeiss adamdickmeiss requested changes

@dcrossleyau dcrossleyau dcrossleyau approved these changes

@wafschneider wafschneider Awaiting requested review from wafschneider

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mis306lu @dcrossleyau @adamdickmeiss