Skip to content

fix(item-storage): improve batch results of the PATCH /item-storage/items endpoint#1304

Merged
psmagin merged 3 commits intomasterfrom
MODORDERS-1372
Feb 9, 2026
Merged

fix(item-storage): improve batch results of the PATCH /item-storage/items endpoint#1304
psmagin merged 3 commits intomasterfrom
MODORDERS-1372

Conversation

@BKadirkhodjaev
Copy link
Contributor

@BKadirkhodjaev BKadirkhodjaev commented Jan 30, 2026 •
edited
Loading

Purpose

Approach

  • Improve executeBatchUpdate to correctly parse the result row set
  • This fix is needed because currently after patching, for example 60 items, the row set only returns data for the first item ignoring 59 other items that were successfully updated in batch

Before the fix we only held 1 record in the updatedItems list

image

After the fix we have all 60 records in the updatedItems list

image

@BKadirkhodjaev BKadirkhodjaev requested a review from a team as a code owner January 30, 2026 11:51
psmagin
psmagin requested changes Jan 31, 2026
View reviewed changes
Copy link
Collaborator

@psmagin psmagin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you for the fix.
Please create ticket in mod-inventory-storage Jira project and use it in this PR title and descirption.
Please update NEWS
Please cover the change with tests if possible

@BKadirkhodjaev BKadirkhodjaev changed the title [MODORDERS-1372]. Use batch endpoint to update items to reduce amount… [MODINVSTOR-1514]. Improve batch results of the PATCH /item-storage/items endpoint Feb 9, 2026
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 9, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@psmagin psmagin changed the title [MODINVSTOR-1514]. Improve batch results of the PATCH /item-storage/items endpoint fix(item-storage): improve batch results of the PATCH /item-storage/items endpoint Feb 9, 2026
@psmagin psmagin merged commit 3473463 into master Feb 9, 2026
16 checks passed
@psmagin psmagin deleted the MODORDERS-1372 branch February 9, 2026 10:08
@BKadirkhodjaev BKadirkhodjaev mentioned this pull request Feb 9, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@psmagin psmagin psmagin approved these changes

@SerhiiNosko SerhiiNosko SerhiiNosko approved these changes

@Saba-Zedginidze-EPAM Saba-Zedginidze-EPAM Saba-Zedginidze-EPAM approved these changes

@viacheslavkol viacheslavkol Awaiting requested review from viacheslavkol viacheslavkol is a code owner automatically assigned from folio-org/spitfire-backend

@SvitlanaKovalova1 SvitlanaKovalova1 Awaiting requested review from SvitlanaKovalova1 SvitlanaKovalova1 is a code owner automatically assigned from folio-org/spitfire-backend

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@BKadirkhodjaev @psmagin @SerhiiNosko @Saba-Zedginidze-EPAM