[MODINVISTO - 177] - Refactoring: Removing deprecated methods and replaced CompatibleFuture to Future and improvements #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 804a030.
azizbekxm
changed the title
azizbekxm
commented
Mar 13, 2024
| SELECT inv.id AS invoice_id, | ||
| to_jsonb(trx.jsonb->>'fiscalYearId') AS fiscal_year_id | ||
| FROM ${myuniversity}_${mymodule}.invoices AS inv | ||
| JOIN ${myuniversity}_mod_finance_storage.transaction AS trx |
Contributor
Author
There was a problem hiding this comment.
SQL script making unit tests failing
azizbekxm
changed the title
|
|
|
|
Azizbek Khushvakov seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
https://folio-org.atlassian.net/browse/MODINVOSTO-177
Approach
Used same refactoring with #171 pr except for sql script
In this pr sql script approach used
Leearning
By using Hash join instead of inner loop increased query performance by 99%
First SQL Script execution time ~8min
Second SQL script executino time ~3sec
reference to further learning
https://dev.to/mahmoudhossam917/nested-join-vs-hash-join-vs-merge-join-in-postgresql-1ha6#:~:text=Nested%20Loop%20Join%20is%20suitable,best%20for%20joining%20sorted%20tables.
https://www.youtube.com/watch?v=pJWCwfv983Q&t=2s