Skip to content

Conversation

@Saba-Zedginidze-EPAM
Copy link
Contributor

@Saba-Zedginidze-EPAM Saba-Zedginidze-EPAM commented Feb 10, 2026

Purpose

[MODORDERS-1402] Add deleteHoldings flag to checkin endpoint and implement holding delete logic

Approach

  • Add new request parameter
  • Use the new param to determine whether to delete holdings
  • Use existing logic for abandoned holdings deletion
  • Update tests

Pre-Review Checklist

  • Self-reviewed Code — Reviewed code for issues, unnecessary parts, and overall quality.
  • Change Notes — NEWS.md updated with clear description and issue key.
  • Testing — Confirmed changes were tested locally or on dev environment.
  • Logging: Confirmed that logging is appropriately handled.
  • Breaking Changes — Handled all required actions if changes affect API, DB, or interface versions.
    • API/schema changes
    • Interface version updates
    • DB schema changes / migration scripts
  • New Properties / Environment Variables — Updated README.md if new configs were added.

@Saba-Zedginidze-EPAM Saba-Zedginidze-EPAM marked this pull request as ready for review February 10, 2026 11:09
@Saba-Zedginidze-EPAM Saba-Zedginidze-EPAM requested a review from a team as a code owner February 10, 2026 11:09
@sonarqubecloud
Copy link

@Saba-Zedginidze-EPAM Saba-Zedginidze-EPAM merged commit 0be1e2c into master Feb 10, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants