-
Notifications
You must be signed in to change notification settings - Fork 37
STCOM-1483 - Lock downshift to v19.0.13 #2522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bigtest Unit Test Results 1 files ±0 1 suites ±0 24s ⏱️ ±0s Results for commit 7e161ef. ± Comparison against base commit bb948d9. This pull request removes 1623 and adds 1623 tests. Note that renamed tests count towards both.This pull request removes 8 skipped tests and adds 8 skipped tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
|
zburke
approved these changes
Feb 3, 2026
github-actions bot
pushed a commit
that referenced
this pull request
Feb 3, 2026
## [STCOM-1483](https://folio-org.atlassian.net/browse/STCOM-1483) v19.2.0 made changes to `useMultiSelection` and `useCombobox` that have broken tests/logic in `<MultiSelection>`. I attempted to switch to using the `useCombobox` state in the `stateReducer` and passing downshift state appropriately to `removeItems` - but this created an issue with tests where removals wouldn't stick - they happened and then were quickly replaced. 🤔 Refactoring to their new features may be the answer - but the amount of state-wrestling that has to be done with this well-intentioned library is exhausting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



STCOM-1483
v19.2.0 made changes to
useMultiSelectionanduseComboboxthat have broken tests/logic in<MultiSelection>.I attempted to switch to using the
useComboboxstate in thestateReducerand passing downshift state appropriately toremoveItems- but this created an issue with tests where removals wouldn't stick - they happened and then were quickly replaced. 🤔Refactoring to their new features may be the answer - but the amount of state-wrestling that has to be done with this well-intentioned library is exhausting.