Skip to content

fix: Attempt to correct MultiSelection behaviour following 9.2.0 downshift changes #2523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
EthanFreestone wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix: Attempt to correct MultiSelection behaviour following 9.2.0 downshift changes #2523

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9fae377
fix: Attempt to correct MultiSelection behaviour following 9.2.0 down…
EthanFreestone Feb 4, 2026
0a4ae52
fix: Added tweak for reset, and changed downshift dependency back to …
EthanFreestone Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions lib/MultiSelection/MultiSelection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ const MultiSelection = ({
case useMultipleSelection.stateChangeTypes
.DropdownKeyDownBackspace:
if (backspaceDeletes) {
handleRemoval(selectedItems, changes.selectedItems, onRemove);
handleRemoval(state.selectedItems, changes.selectedItems, onRemove);
awaitingChange.current = true;
userSelection.current = changes.selectedItems;
}
Expand All @@ -210,7 +210,7 @@ const MultiSelection = ({
case useMultipleSelection.stateChangeTypes
.FunctionRemoveSelectedItem:
// this calls the onRemove handle for the variety of different ways that a selected option can be removed.
handleRemoval(selectedItems, changes.selectedItems, onRemove);
handleRemoval(state.selectedItems, changes.selectedItems, onRemove);
awaitingChange.current = true;
userSelection.current = changes.selectedItems;
return changes;
Expand Down Expand Up @@ -277,20 +277,20 @@ const MultiSelection = ({
filterText: filterValue,
inputValue: filterValue,
selectedItems,
reset
reset: state.reset
});
setFilterValue('');
return {
isOpen: false, // close the menu.
highlightedIndex, // don't move highlight cursor back to top of list on selection.
highlightedIndex: state.highlightedIndex, // don't move highlight cursor back to top of list on selection.
}
} else {
awaitingChange.current = true;
}
return {
...changes,
isOpen: true, // keep the menu open after selection.
highlightedIndex, // don't move highlight cursor back to top of list on selection.
highlightedIndex: state.highlightedIndex, // don't move highlight cursor back to top of list on selection.
}
default:
return changes
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
"classnames": "^2.2.5",
"currency-codes": "2.1.0",
"dayjs": "^1.11.10",
"downshift": "9.0.13",
"downshift": "^9.0.4",
"flexboxgrid2": "^7.2.0",
"focus-trap": "^7.5.4",
"json2csv": "^4.2.1",
Expand All @@ -123,4 +123,4 @@
"react-redux": "^8.0.5",
"react-router-dom": "^5.2.0"
}
}
}
Loading
Loading