Open
Conversation
Bigtest Unit Test Results189 tests ±0 184 ✅ ±0 7s ⏱️ -1s Results for commit b16a2c2. ± Comparison against base commit 165587c. This pull request removes 191 and adds 189 tests. Note that renamed tests count towards both.This pull request removes 5 skipped tests and adds 5 skipped tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
zburke
approved these changes
Apr 8, 2025
Member
zburke
left a comment
There was a problem hiding this comment.
Nah, BRING THE NOISE!!!
Alternatively, we could resolve the react-intl complaints by updating package.json like
"test:bigtest": "stripes translate compile && stripes test karma",
|
Member
|
@JohnC-80 , another alternative to tweaking console: use stripes-config to tell stripes-core to tell react-intl to STFU by setting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This PR fixes one potentially flakey test by removing a 404 on an image from some static JSON that was included with the test suite. I moved the static JSON into the test file and imported the
svgas similar tests forAppIcondo...Additionally, added a bit to
setupApplicationto suppress the console noise warnings from[@formatjs/intl]about compiling translations that happen any time a<FormattedMessage>renders. Leaving some other console messages in there - i.e. Mirage messages about the app trying to access unhandled endpoints.