Discussion: Can we change react to react-jsx in tsconfig.json to avoid unnecessary import React from 'react'#167
Draft
EthanFreestone wants to merge 1 commit intomainfrom
Draft
Discussion: Can we change react to react-jsx in tsconfig.json to avoid unnecessary import React from 'react'#167EthanFreestone wants to merge 1 commit intomainfrom
react to react-jsx in tsconfig.json to avoid unnecessary import React from 'react'#167EthanFreestone wants to merge 1 commit intomainfrom
Conversation
…import React from 'react'` at the top of all `.tsx` files We should also look into changing moduleResolution, as `node` appears to be an alias for node10, designed for use with versions of Node <= 10 However changing this ALSO requires a change to the `module` configuration, and changes there seemed to brick ui-mosaic-settings, so I have left alone for now
ncovercash
approved these changes
Aug 13, 2025
ncovercash
changed the title
react to react--jsx in tsconfig.json to avoid unnecessary import React from 'react'react to react-jsx in tsconfig.json to avoid unnecessary import React from 'react'
Author
|
@SerhiiNosko This change has been tested in platform-complete without |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build: Change jsx configuration to
react-jsxto avoid unnecessaryimport React from 'react'at the top of all.tsxfilesWe should also look into changing moduleResolution, asnodeappears to be an alias for node10, designed for use with versions of Node <= 10However changing this ALSO requires a change to themoduleconfiguration, and changes there seemed to brick ui-mosaic-settings, so I have left alone for nowSee https://stackoverflow.com/questions/71463698/why-we-need-nodenext-typescript-compiler-option-when-we-have-esnext and @ncovercash comments on thread: https://open-libr-foundation.slack.com/archives/CAN13SWBF/p1755094505685999?thread_ts=1755084794.784919&cid=CAN13SWBF
Seems like the current confiig is quite possibly the best for what we're doing right now as far as moduleResolution is concerned