Conversation
ncovercash
commented
Sep 18, 2024
| setTokenExpiration(te ?? { atExpires: -1, rtExpires: -1 }); | ||
| setIsLoading(false); | ||
| }); | ||
| setIsLoading(true); |
Member
Author
There was a problem hiding this comment.
this is goofy, but eslint got mad and insisted it was always false
mweaver-ebsco
approved these changes
Sep 19, 2024
zburke
requested changes
Sep 19, 2024
Member
zburke
left a comment
zburke
left a comment
There was a problem hiding this comment.
The code itself looks fine but you're missing a required update in package.json and the stripes-core import appears to be based on a local workspace config, not a real-world bundle scenario.
Member
Author
|
@zburke should be fixed — also added the |
Copying the value of the constant into this component, instead of importing it from stripes-core, gives us the same end result without requiring us to bump the peer-dep on stripes up from `^9.1.0` to `^9.2.0`, allowing this release to remain compatible with Q. Refs UID-159
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
folio-org/stripes-core#1535 must be merged before this PR can pass