You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This way was implemented for Titles list for package in UIEH-1004 PR.
Here a <QuerySearchList> component was created for this implementation. For other package / header / provider implementations, developers will need to change <QueryList> to <QuerySearchList> and add epics to get the collection. The PR for UIEH-1004 can be used as a code base.
The preliminary estimate of each task to change the pagination will be no more than 3-5 SP.
It is easier to implement this based on the previous method. It has the same code with minor changes in the reducer and changes the load more button to next-prev buttons. How this can be implemented is described in the code for the current PR.
For this way we need one ticket to change <QuerySearchList> component with next-prev buttons. And estimate it as 2 SP. And other thickets for packages/titles/providers/ lists could be 5 SP.
It is difficult to check because this functionality is not merged. But it has a simple implementation (based on the documentation) and our code already has all the necessary details for its implementation. For this way we need story for implementing <Pagination> component for <QuerySearchList>. It could be estimate as 5 SP. And other tickets for lists could be 5 SP too.
Focus functionality
It will be working the similar for all of this ways. But it's difficult functionality and we need the separate story for its implementation.
yarn run v1.22.5
$ eslint ./ && stylelint "src/**/*.css"
/home/jenkins/workspace/folio-org_ui-eholdings_PR-1382/project/src/components/query-search-list/query-search-list.js
6:10 error 'FormattedMessage' is defined but never used no-unused-vars
68:81 error Trailing spaces not allowed no-trailing-spaces
82:7 error Trailing spaces not allowed no-trailing-spaces
/home/jenkins/workspace/folio-org_ui-eholdings_PR-1382/project/src/hooks/useFetchExportTitlesFromPackage.js
35:21 warning React Hook useCallback does nothing when called with only one argument. Did you forget to pass an array of dependencies? react-hooks/exhaustive-deps
/home/jenkins/workspace/folio-org_ui-eholdings_PR-1382/project/src/routes/settings-usage-consolidation-route.js
131:6 warning React Hook useCallback has missing dependencies: 'usageConsolidationData.credentialsId' and 'usageConsolidationData.customerKey'. Either include them or remove the dependency array react-hooks/exhaustive-deps
✖ 5 problems (3 errors, 2 warnings)
2 errors and 0 warnings potentially fixable with the --fix option.
yarn run v1.22.5
$ eslint ./ && stylelint "src/**/*.css"
/home/jenkins/workspace/folio-org_ui-eholdings_PR-1382/project/src/components/navigation-modal/navigation-modal.js
52:15 warning Assignments to the 'unblock' variable from inside React Hook useEffect will be lost after each render. To preserve the value over time, store it in a useRef Hook and keep the mutable value in the '.current' property. Otherwise, you can move this variable directly inside useEffect react-hooks/exhaustive-deps
/home/jenkins/workspace/folio-org_ui-eholdings_PR-1382/project/src/components/package/show/package-show.js
137:6 warning React Hook useEffect has missing dependencies: 'model.allowKbToAddTitles' and 'model.isSelected'. Either include them or remove the dependency array. If 'setPackageSelected' needs the current value of 'model.isSelected', you can also switch to useReducer instead of useState and read 'model.isSelected' in the reducer react-hooks/exhaustive-deps
/home/jenkins/workspace/folio-org_ui-eholdings_PR-1382/project/src/components/query-search-list/query-search-list.js
6:10 error 'FormattedMessage' is defined but never used no-unused-vars
68:81 error Trailing spaces not allowed no-trailing-spaces
82:7 error Trailing spaces not allowed no-trailing-spaces
/home/jenkins/workspace/folio-org_ui-eholdings_PR-1382/project/src/hooks/useFetchExportTitlesFromPackage.js
35:21 warning React Hook useCallback does nothing when called with only one argument. Did you forget to pass an array of dependencies? react-hooks/exhaustive-deps
/home/jenkins/workspace/folio-org_ui-eholdings_PR-1382/project/src/routes/settings-usage-consolidation-route.js
131:6 warning React Hook useCallback has missing dependencies: 'usageConsolidationData.credentialsId' and 'usageConsolidationData.customerKey'. Either include them or remove the dependency array react-hooks/exhaustive-deps
✖ 7 problems (3 errors, 4 warnings)
2 errors and 0 warnings potentially fixable with the --fix option.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UIEH-1141: Investigate : Change results list scrolling behavior
Story
UIEH-1141
Description
Throughout this work, it was revealed
Load more button pagination
This way was implemented for Titles list for package in UIEH-1004 PR.

Here a
<QuerySearchList>component was created for this implementation. For other package / header / provider implementations, developers will need to change<QueryList>to<QuerySearchList>and add epics to get the collection. The PR for UIEH-1004 can be used as a code base.The preliminary estimate of each task to change the pagination will be no more than 3-5 SP.
NextPrev buttons pagination (STCOM-829)
It is easier to implement this based on the previous method. It has the same code with minor changes in the reducer and changes the load more button to

next-prevbuttons. How this can be implemented is described in the code for the current PR.For this way we need one ticket to change
<QuerySearchList>component withnext-prevbuttons. And estimate it as 2 SP. And other thickets for packages/titles/providers/ lists could be 5 SP.Pagination from STCOM-827
It is difficult to check because this functionality is not merged. But it has a simple implementation (based on the documentation) and our code already has all the necessary details for its implementation. For this way we need story for implementing
<Pagination>component for<QuerySearchList>. It could be estimate as 5 SP. And other tickets for lists could be 5 SP too.Focus functionality
It will be working the similar for all of this ways. But it's difficult functionality and we need the separate story for its implementation.