Closed
Conversation
Jest Unit Test Results 1 files ±0 316 suites ±0 10m 14s ⏱️ +8s For more details on these failures, see this check. Results for commit 58aadb6. ± Comparison against base commit b863568. ♻️ This comment has been updated with latest results. |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
Contributor
|
Will be done here: |
elsenhans
deleted the
UIIN-3540-add-formatting-to-additional-call-numbers
branch
elsenhans
added a commit
to folio-org/stripes-components
that referenced
this pull request
Dec 22, 2025
# Description These changes add the possibility to pass a customItemFormatter to the AuditLogModal and add to this Formatter the collectionName. # Why is this change necessary? While adding additionalCallNumbers to the inventorys item history as requested per this user story: https://folio-org.atlassian.net/browse/UIIN-3540 we noticed, that objects are currently being displayed as unordered, unnamed lists. This seems to be deficient as the user has to guess which value belongs to which property. By adding a custom formatter, we are able to display these objects like this: <img width="2978" height="1269" alt="Screenshot from 2025-12-11 15-54-34" src="https://github.com/user-attachments/assets/8ea804fd-6dcf-4dea-8825-c931c1b9b171" /> # Related changes ## Mod-Audit folio-org/mod-audit#229 ## UI-Inventory folio-org/ui-inventory#2950 --------- Co-authored-by: elsenhans <elsenhans@users.noreply.github.com> Co-authored-by: elsenhans <48911833+elsenhans@users.noreply.github.com>
github-actions bot
pushed a commit
to folio-org/stripes-components
that referenced
this pull request
Dec 22, 2025
# Description These changes add the possibility to pass a customItemFormatter to the AuditLogModal and add to this Formatter the collectionName. # Why is this change necessary? While adding additionalCallNumbers to the inventorys item history as requested per this user story: https://folio-org.atlassian.net/browse/UIIN-3540 we noticed, that objects are currently being displayed as unordered, unnamed lists. This seems to be deficient as the user has to guess which value belongs to which property. By adding a custom formatter, we are able to display these objects like this: <img width="2978" height="1269" alt="Screenshot from 2025-12-11 15-54-34" src="https://github.com/user-attachments/assets/8ea804fd-6dcf-4dea-8825-c931c1b9b171" /> # Related changes ## Mod-Audit folio-org/mod-audit#229 ## UI-Inventory folio-org/ui-inventory#2950 --------- Co-authored-by: elsenhans <elsenhans@users.noreply.github.com> Co-authored-by: elsenhans <48911833+elsenhans@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
While adding additionalCallNumbers to the inventorys' item history as requested per this user story: https://folio-org.atlassian.net/browse/UIIN-3540 we noticed, that objects are currently being displayed as unordered, unnamed lists. This seems to be deficient as the user has to guess which value belongs to which property.
Approach
We define and pass a customItemFormatter to the AuditLogModal which allows us to display object properties as name-value pairs.
See screenshots.
Refs
https://folio-org.atlassian.net/browse/UIIN-3540
Screenshots