googlefonts/axes_match: check added #4836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 19, 2024
Closed
m4rc1e
force-pushed
the
axis-regress
branch
2 times, most recently
from
2377baf
to
14fb775
Compare
"Check the font isn't missing any axes and the axes have the same range as the Google Fonts version." Added to the Google Fonts profile. (PR #4836)
felipesanches
force-pushed
the
axis-regress
branch
from
278c5e6
to
613edf7
Compare
|
thanks, @m4rc1e ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When we update a family on Google Fonts, it must include the same axes and axes ranges as the previous release. If we don't, we'll end up breaking the googlefonts css2 api.
Checklist
CHANGELOG.md@felipesanches I'll finish this off tomorrow.