Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: accounts transaction loading [web-archway] #1306

Merged
merged 11 commits into from
Oct 6, 2023
Merged

fix: accounts transaction loading [web-archway] #1306

merged 11 commits into from
Oct 6, 2023

Conversation

MonikaCat
Copy link
Contributor

Description

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • ran linting via yarn lint
  • wrote tests where necessary
  • included the correct type prefix in the PR title
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed
  • added a changeset via yarn && yarn changeset

@vercel
Copy link

vercel bot commented Oct 4, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cosmos ✅ Ready (Inspect) Visit Preview Oct 6, 2023 2:32am

@MonikaCat MonikaCat changed the title fix: accounts transaction loading fix: accounts transaction loading [web-archway] Oct 4, 2023
@MonikaCat MonikaCat added the automerge Automatically merge PR once all prerequisites pass label Oct 4, 2023
@MonikaCat MonikaCat requested a review from icfor October 4, 2023 10:26
icfor
icfor previously approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@icfor icfor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM , it looks like there is an error in deployment but not related to changes

Error: No Next.js version could be detected in your project. Make sure "next" is installed in "dependencies" or "devDependencies"

Will that be fixed when merging?

icfor
icfor previously approved these changes Oct 4, 2023
View reviewed changes
@MonikaCat MonikaCat changed the title fix: accounts transaction loading [web-archway] fix: accounts transaction loading [web] Oct 4, 2023
@icfor icfor changed the title fix: accounts transaction loading [web] fix: accounts transaction loading [web-archway] Oct 6, 2023
@MonikaCat MonikaCat merged commit 61b3c8e into main Oct 6, 2023
@MonikaCat MonikaCat deleted the dev/fix-account-page-loading branch October 6, 2023 02:52
@github-actions github-actions bot mentioned this pull request Oct 6, 2023
Open
@github-actions github-actions bot mentioned this pull request Oct 13, 2023
Open
This was referenced Jan 22, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icfor icfor icfor approved these changes

Assignees
No one assigned
Labels
automerge Automatically merge PR once all prerequisites pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MonikaCat @icfor