32129139: Wrap 3rd-party libraries that don't have any ES export #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The line import jQuery from "jquery"; implies that the library "jquery" has a default export. This is not the case and the line above only works because we use Webpack. This commit wraps each library that do not export an ES-module.
|
Not ready! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The line
import jQuery from "jquery";
implies that the library "jquery" has a default export. This is
not the case and the line above only works because we use Webpack.
This commit wraps each library that do not export an ES-module.
Basecamp: https://3.basecamp.com/4201305/buckets/32129139/todos/7253917413
This change is