32129139: Remove webpack from widgetjs #477
Conversation
The line import jQuery from "jquery"; implies that the library "jquery" has a default export. This is not the case and the line above only works because we use Webpack. This commit wraps each library that do not export an ES-module.
DamienCassou
requested review from
danglotb,
josquindebaz,
ValentinaVasile and
JohanBriglia
There was a problem hiding this comment.
Reviewed 10 of 10 files at r1, 2 of 2 files at r2, 7 of 7 files at r3, 2 of 2 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @BenjaminVanRyseghem, @DamienCassou, @danglotb, @JohanBriglia, and @josquindebaz)
a discussion (no related file):
Maybe an explanation why we remove webpack? My guess is that is not used anymore but still :)
We don't need any bundler anymore. Users of the library can just import the source file they need and rely on their own bundler if they want to.
DamienCassou
force-pushed
the
32129139/Remove_webpack_from_widgetjs
branch
from
041ac70 to
e4dfc3b
Compare
This is the only part we need.
DamienCassou
force-pushed
the
32129139/Remove_webpack_from_widgetjs
branch
from
2707236 to
cd68ab1
Compare
There was a problem hiding this comment.
Reviewable status: 11 of 21 files reviewed, 1 unresolved discussion (waiting on @BenjaminVanRyseghem, @danglotb, @JohanBriglia, @josquindebaz, and @ValentinaVasile)
a discussion (no related file):
Previously, ValentinaVasile (Valentina Vasile) wrote…
Maybe an explanation why we remove webpack? My guess is that is not used anymore but still :)
you are right. I added that to the commit message.
There was a problem hiding this comment.
Reviewed 10 of 10 files at r1, 2 of 2 files at r2, 9 of 9 files at r5, 7 of 7 files at r6, 2 of 2 files at r7, 2 of 2 files at r8, 2 of 2 files at r9, 1 of 1 files at r10, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @BenjaminVanRyseghem, @danglotb, @JohanBriglia, and @ValentinaVasile)
There was a problem hiding this comment.
Reviewed 10 of 10 files at r1, 2 of 2 files at r2, 9 of 9 files at r5, 7 of 7 files at r6, 2 of 2 files at r7, 2 of 2 files at r8, 2 of 2 files at r9, 1 of 1 files at r10, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @danglotb, @JohanBriglia, and @ValentinaVasile)
basecamp: https://3.basecamp.com/4201305/buckets/32129139/todos/7253918698
This change is