32129139: Change widgetjs package type to "module" #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DamienCassou
requested review from
danglotb,
josquindebaz,
ValentinaVasile and
JohanBriglia
BenjaminVanRyseghem
approved these changes
Apr 5, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 2 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @danglotb, @JohanBriglia, @josquindebaz, and @ValentinaVasile)
Our files are modules, better to declare it properly.
This is important now that the package is of type module. Otherwise, eslint will try to load them as modules and it will crash.
This is done separately from the previous commit to make sure Git sees a file rename in the previous commit.
DamienCassou
force-pushed
the
32129139/Change_widgetjs_package_type_to_module_
branch
from
dd3e262 to
9eea30b
Compare
DamienCassou
deleted the
32129139/Change_widgetjs_package_type_to_module_
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our files are modules, better to declare it properly.
https://3.basecamp.com/4201305/buckets/32129139/todos/7263933756
This change is