Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

32129139: Use jest+jsdom+majestic instead of jasmine in widgetjs #482

Merged
merged 3 commits into from
Apr 11, 2024
Merged

32129139: Use jest+jsdom+majestic instead of jasmine in widgetjs #482

merged 3 commits into from
Apr 11, 2024

Conversation

DamienCassou
Copy link
Member

@DamienCassou DamienCassou commented Apr 5, 2024 •
edited
Loading

@DamienCassou DamienCassou changed the title 32129139: Try jest+jsdom+majestic instead of jasmine in widgetjs 32129139: Use jest+jsdom+majestic instead of jasmine in widgetjs Apr 5, 2024
@DamienCassou DamienCassou force-pushed the 32129139/Try_jest_jsdom_majestic_instead_of_jasmine_in_widgetjs branch from f773ac6 to d11353a Compare April 5, 2024 16:16
@DamienCassou DamienCassou force-pushed the 32129139/Try_jest_jsdom_majestic_instead_of_jasmine_in_widgetjs branch from d11353a to 1c304dd Compare April 10, 2024 07:38
@DamienCassou DamienCassou force-pushed the 32129139/Try_jest_jsdom_majestic_instead_of_jasmine_in_widgetjs branch from 1c304dd to 10544f8 Compare April 10, 2024 07:42
@DamienCassou DamienCassou marked this pull request as ready for review April 10, 2024 07:42
danglotb
danglotb approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@danglotb danglotb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 7 of 7 files at r1, 12 of 12 files at r2, 5 of 5 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @BenjaminVanRyseghem, @JohanBriglia, @josquindebaz, and @ValentinaVasile)

josquindebaz
josquindebaz approved these changes Apr 10, 2024
View reviewed changes
Copy link

@josquindebaz josquindebaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1, 12 of 12 files at r2, 5 of 5 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @BenjaminVanRyseghem, @JohanBriglia, and @ValentinaVasile)

josquindebaz
josquindebaz approved these changes Apr 10, 2024
View reviewed changes
Copy link

@josquindebaz josquindebaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1, 12 of 12 files at r2, 5 of 5 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @BenjaminVanRyseghem, @JohanBriglia, and @ValentinaVasile)

@DamienCassou DamienCassou merged commit 2343bdb into master Apr 11, 2024
2 checks passed
@DamienCassou DamienCassou deleted the 32129139/Try_jest_jsdom_majestic_instead_of_jasmine_in_widgetjs branch April 11, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josquindebaz josquindebaz josquindebaz approved these changes

@danglotb danglotb danglotb approved these changes

@BenjaminVanRyseghem BenjaminVanRyseghem Awaiting requested review from BenjaminVanRyseghem BenjaminVanRyseghem is a code owner

@ValentinaVasile ValentinaVasile Awaiting requested review from ValentinaVasile

@JohanBriglia JohanBriglia Awaiting requested review from JohanBriglia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DamienCassou @danglotb @josquindebaz