32129139: Sort methods of Widget2 #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DamienCassou
requested review from
danglotb,
josquindebaz,
ValentinaVasile and
JohanBriglia
danglotb
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @BenjaminVanRyseghem, @JohanBriglia, @josquindebaz, and @ValentinaVasile)
josquindebaz
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @BenjaminVanRyseghem, @JohanBriglia, and @ValentinaVasile)
There are several problems with grouping markup: - many methods are in the wrong group - we sometimes have the same group twice in a single file - as far as I know nobody has any tooling (to navigate, to fold, to insert, …) for the markup, making them barely useful - if we need to group methods it may be an indication that the class is too big and it could be better to refactor it
DamienCassou
force-pushed
the
32129139/Sort_methods_of_Widget2
branch
from
b9b81b0 to
e6ff346
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://3.basecamp.com/4201305/buckets/32129139/todos/7278561230
This change is