32129139: Improve some unit tests

[DamienCassou]

https://3.basecamp.com/4201305/buckets/32129139/todos/7278579439

This change is 

[ValentinaVasile]

Reviewed 1 of 1 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, 1 of 1 files at r4.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @BenjaminVanRyseghem, @DamienCassou, @danglotb, @JohanBriglia, and @josquindebaz)

---

src/test/router/routerTest.js line 187 at r4 (raw file):

		// Assert that callback was executed
		expect(spy).toHaveBeenCalledWith(jasmine.anything());
	});

Why is this assertion better than the previous one?

[DamienCassou]

Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @BenjaminVanRyseghem, @danglotb, @JohanBriglia, @josquindebaz, and @ValentinaVasile)

---

src/test/router/routerTest.js line 187 at r4 (raw file):

Previously, ValentinaVasile (Valentina Vasile) wrote…

Why is this assertion better than the previous one?

it checks the function was called with one and only one argument. Not much better I agree but some eslint rules forbid the use of toHaveBeenCalled().

[ValentinaVasile]

Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @BenjaminVanRyseghem, @DamienCassou, @danglotb, @JohanBriglia, and @josquindebaz)

---

src/test/router/routerTest.js line 187 at r4 (raw file):

Previously, DamienCassou (Damien Cassou) wrote…

it checks the function was called with one and only one argument. Not much better I agree but some eslint rules forbid the use of toHaveBeenCalled().

thanks for the answer

[josquindebaz]

Reviewed 1 of 1 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @BenjaminVanRyseghem, @DamienCassou, @danglotb, and @JohanBriglia)

[josquindebaz]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @BenjaminVanRyseghem, @DamienCassou, @danglotb, and @JohanBriglia)