-
Notifications
You must be signed in to change notification settings - Fork 5
37849678: Bump @foretagsplatsen/eslint-plugin in widgetjs #499
37849678: Bump @foretagsplatsen/eslint-plugin in widgetjs #499
Conversation
d5e5e86
to
bdb6f70
Compare
f386bd9
to
20f189f
Compare
20f189f
to
cc5fd4b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 5 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @BenjaminVanRyseghem, @danglotb, @JohanBriglia, and @josquindebaz)
cc5fd4b
to
0065df5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 5 files at r1, 2 of 3 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @BenjaminVanRyseghem, @JohanBriglia, and @josquindebaz)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 5 files at r1, 2 of 3 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @DamienCassou, @JohanBriglia, and @josquindebaz)
package.json
line 7 at r3 (raw file):
"homepage": "http://github.com/foretagsplatsen/widgetjs", "exports": { ".": "./src/widgetjs.js"
nit: is this needed?
0065df5
to
8c0b195
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r1.
Reviewable status: 4 of 5 files reviewed, 3 unresolved discussions (waiting on @BenjaminVanRyseghem, @danglotb, @dev-amin, @JohanBriglia, and @josquindebaz)
package.json
line 46 at r1 (raw file):
}, "devDependencies": { "@foretagsplatsen/eslint-plugin": "^8.0.0-beta",
we should remove the "beta"
package.json
line 47 at r1 (raw file):
"devDependencies": { "@foretagsplatsen/eslint-plugin": "^8.0.0-beta", "@stylistic/eslint-plugin-js": "2.1.0",
this should go away
package.json
line 7 at r3 (raw file):
Previously, BenjaminVanRyseghem (Benjamin Van Ryseghem) wrote…
nit: is this needed?
no, thank you. Reverted
This change is