Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

37849678: Bump @foretagsplatsen/eslint-plugin in widgetjs #499

Merged

Conversation

DamienCassou
Copy link
Member

@DamienCassou DamienCassou commented Jun 12, 2024

This change is Reviewable

@BenjaminVanRyseghem BenjaminVanRyseghem force-pushed the 37849678/Bump_foretagsplatsen_eslint-plugin_in_widgetjs branch from d5e5e86 to bdb6f70 Compare June 14, 2024 13:42
@BenjaminVanRyseghem
Copy link
Contributor

@BenjaminVanRyseghem BenjaminVanRyseghem force-pushed the 37849678/Bump_foretagsplatsen_eslint-plugin_in_widgetjs branch 5 times, most recently from f386bd9 to 20f189f Compare June 17, 2024 08:23
@BenjaminVanRyseghem BenjaminVanRyseghem marked this pull request as ready for review June 17, 2024 08:30
@BenjaminVanRyseghem BenjaminVanRyseghem self-requested a review as a code owner June 17, 2024 08:30
@DamienCassou DamienCassou force-pushed the 37849678/Bump_foretagsplatsen_eslint-plugin_in_widgetjs branch from 20f189f to cc5fd4b Compare June 17, 2024 08:55
Copy link

@dev-amin dev-amin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 5 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @BenjaminVanRyseghem, @danglotb, @JohanBriglia, and @josquindebaz)

@DamienCassou DamienCassou force-pushed the 37849678/Bump_foretagsplatsen_eslint-plugin_in_widgetjs branch from cc5fd4b to 0065df5 Compare June 17, 2024 09:01
Copy link
Member

@danglotb danglotb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 5 files at r1, 2 of 3 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @BenjaminVanRyseghem, @JohanBriglia, and @josquindebaz)

Copy link
Contributor

@BenjaminVanRyseghem BenjaminVanRyseghem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 5 files at r1, 2 of 3 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @DamienCassou, @JohanBriglia, and @josquindebaz)


package.json line 7 at r3 (raw file):

  "homepage": "http://github.com/foretagsplatsen/widgetjs",
  "exports": {
    ".": "./src/widgetjs.js"

nit: is this needed?

@DamienCassou DamienCassou force-pushed the 37849678/Bump_foretagsplatsen_eslint-plugin_in_widgetjs branch from 0065df5 to 8c0b195 Compare June 17, 2024 10:28
Copy link
Member Author

@DamienCassou DamienCassou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1.
Reviewable status: 4 of 5 files reviewed, 3 unresolved discussions (waiting on @BenjaminVanRyseghem, @danglotb, @dev-amin, @JohanBriglia, and @josquindebaz)


package.json line 46 at r1 (raw file):

  },
  "devDependencies": {
    "@foretagsplatsen/eslint-plugin": "^8.0.0-beta",

we should remove the "beta"


package.json line 47 at r1 (raw file):

  "devDependencies": {
    "@foretagsplatsen/eslint-plugin": "^8.0.0-beta",
    "@stylistic/eslint-plugin-js": "2.1.0",

this should go away


package.json line 7 at r3 (raw file):

Previously, BenjaminVanRyseghem (Benjamin Van Ryseghem) wrote…

nit: is this needed?

no, thank you. Reverted

@DamienCassou DamienCassou merged commit 2d5e10f into master Jun 17, 2024
1 of 2 checks passed
@DamienCassou DamienCassou deleted the 37849678/Bump_foretagsplatsen_eslint-plugin_in_widgetjs branch June 17, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants