Replace custom Base64 with java.util.Base64 #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the 700+ line third-party Base64 implementation from iharder.net and use Java's standard library java.util.Base64 (available since Java 8). This simplifies the codebase and reduces maintenance burden. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Use _root_.java.util.Base64 to avoid shadowing by com.twitter.chill.java package. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The Base64 class was removed in favor of java.util.Base64 (available since Java 8). Add MIMA exclusions to allow this intentional breaking change. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
java.util.Base64(available since Java 8)Changes
chill-java/src/main/java/com/twitter/chill/Base64.javaConfiguredInstantiator.javato usejava.util.Base64Test plan
ReflectingInstantiatorTestwhich tests serialized instantiators)🤖 Generated with Claude Code