Fix: address review issues from PR #12 #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Pass Gemini API key via x-goog-api-key header instead of URL query
parameter to prevent key leakage in logs and tracebacks
- Use Gemini SDK's native system_instruction parameter instead of
concatenating system messages into the user prompt
- Deduplicate _build_sdk_contents and _build_http_contents into a
single _build_contents method
- Redact error messages in llm_call_failed trace events using
redact_text() to prevent sensitive data in traces
- Fix _extract_protocol_info reading wrong key ("protocol" vs
"protocol_name") causing empty protocol name in inspect output
- Fix CLI catch-all error message referencing ANTHROPIC_API_KEY
instead of being provider-agnostic
- Wire check_llm_allowed_in_step runtime guard into the engine's
PROPOSE step to enforce the LLM-only-in-WORK invariant
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 7 issues identified during code review of PR #12:
x-goog-api-keyheader instead of URL query parameter to prevent leakage in logs/tracebackssystem_instructionparameter instead of concatenating system messages into the user prompt_build_sdk_contentsand_build_http_contentsinto a single_build_contentsmethodredact_text()tollm_call_failedtrace error messages to prevent sensitive data in traces_extract_protocol_infowas reading"protocol"instead of"protocol_name", causing empty protocol name in inspect outputANTHROPIC_API_KEYinstead of being provider-agnosticcheck_llm_allowed_in_step("work")runtime guard in the engine to enforce the LLM-only-in-WORK invariantTest plan
🤖 Generated with Claude Code