ROASTER-1: Java Statement Fluent Model #27

sotty · 2014-09-08T03:17:06Z

Update Copyright

gastaldi · 2014-09-08T04:05:20Z

The changes in MethodImpl are not updated to the last commit, could you fix that? Thanks.

sotty · 2014-09-08T04:18:39Z

oops something went wrong with the rebase.. should be fixed now

gastaldi · 2014-11-12T15:19:12Z

It looks like it is not using the Forge formatter. Could you apply the formatter and rebase with the latest master?

Thanks!

gastaldi · 2014-11-12T15:19:58Z

This is the formatter used in Eclipse: https://raw.githubusercontent.com/forge/core/master/eclipse-code-formatter-profile.xml

agoncal · 2015-04-17T16:32:05Z

What about having a method MethodSource<O> setBody( Statement... blocks ); ? This would allow something like :

    method.setBody(
            newDeclare().setVariable(Integer.class, "y"),
            newDeclare().setVariable(String.class, "x")
    );

WDYT ?

sotty · 2015-04-18T00:21:59Z

Agreed. Actually it's already in the next version of this PR, which I haven't committed yet :)

agoncal · 2015-04-18T13:07:12Z

Cool. Commit it and I'll give it a try

gastaldi · 2015-07-26T04:46:35Z

api/src/main/java/org/jboss/forge/roaster/model/JavaClass.java

@@ -33,4 +34,5 @@
    */
   public boolean isLocalClass();

+   public JavaClassSource asJavaClassSource();


Why is this method needed?

Leftover, removed

On Sat, Jul 25, 2015 at 11:46 PM, George Gastaldi notifications@github.com
wrote:

In api/src/main/java/org/jboss/forge/roaster/model/JavaClass.java
#27 (comment):

@@ -33,4 +34,5 @@
*/
public boolean isLocalClass();

public JavaClassSource asJavaClassSource();

Why is this method needed?

—
Reply to this email directly or view it on GitHub
https://github.com/forge/roaster/pull/27/files#r35489315.

Update Copyright Conflicts: api/src/main/java/org/jboss/forge/roaster/model/source/MethodSource.java impl/src/main/java/org/jboss/forge/roaster/model/impl/AnnotationImpl.java impl/src/main/java/org/jboss/forge/roaster/model/impl/MethodImpl.java Conflicts: impl/src/main/java/org/jboss/forge/roaster/model/impl/MethodImpl.java

sotty · 2015-07-26T15:07:22Z

Next item is checking the consistency of the internal "origin"/"parent" tree

gastaldi · 2015-07-27T19:29:46Z

api/src/main/java/org/jboss/forge/roaster/model/JavaClass.java

@@ -8,6 +8,7 @@
 package org.jboss.forge.roaster.model;

 import org.jboss.forge.roaster.Roaster;
+import org.jboss.forge.roaster.model.source.JavaClassSource;


Unused import

gastaldi · 2015-07-27T19:34:15Z

I like this, excellent job!

gastaldi · 2015-07-28T20:21:45Z

How is parsing of statements work in this proposal? Suppose you want to change some statement in an existing class (change the for loop condition, add another statement), how will this be possible?

gastaldi · 2015-07-28T20:24:23Z

impl/src/main/java/org/jboss/forge/roaster/model/impl/statements/StatementImpl.java

+import org.jboss.forge.roaster.model.source.JavaSource;
+import org.jboss.forge.roaster.model.statements.Statement;
+
+public abstract class StatementImpl<O extends JavaSource<O>,


Can we have more meaningful names for these generics?

Yes, but for uniformity that would need to happen across all the codebase

sotty · 2015-07-28T21:39:29Z

This is the new feature I (and Mario) started adding in the latest
iteration. It needs more testing and some more work, but see the test case
here:
mpl/src/test/java/org/jboss/forge/test/roaster/model/statements/ModifyMethodBodyTest.java

On Tue, Jul 28, 2015 at 3:21 PM, George Gastaldi notifications@github.com
wrote:

How is parsing of statements work in this proposal? Suppose you want to
change some statement in an existing class (change the for loop condition,
add another statement), how will this be possible?

—
Reply to this email directly or view it on GitHub
#27 (comment).

sotty · 2015-07-28T21:40:54Z

Oops broken paste :)
https://github.com/sotty/roaster/blob/master/impl/src/test/java/org/jboss/forge/test/roaster/model/statements/ModifyMethodBodyTest.java

On Tue, Jul 28, 2015 at 4:39 PM, Davide Sottara dsotty@gmail.com wrote:

This is the new feature I (and Mario) started adding in the latest
iteration. It needs more testing and some more work, but see the test case
here:

mpl/src/test/java/org/jboss/forge/test/roaster/model/statements/ModifyMethodBodyTest.java

On Tue, Jul 28, 2015 at 3:21 PM, George Gastaldi <notifications@github.com

wrote:

How is parsing of statements work in this proposal? Suppose you want to
change some statement in an existing class (change the for loop condition,
add another statement), how will this be possible?

—
Reply to this email directly or view it on GitHub
#27 (comment).

jamestyrrell · 2016-07-05T06:47:15Z

Any update on this?

forge-bot · 2016-07-05T06:47:16Z

Can one of the admins verify this patch?

gastaldi · 2016-07-06T15:16:18Z

@sotty, are you still working on this PR?

sotty · 2016-07-06T15:18:44Z

I am, and I have just come back to development this week after a long
period working on other things.
So expect to hear back from me very soon

On Wed, Jul 6, 2016 at 10:16 AM, George Gastaldi notifications@github.com
wrote:

@sotty https://github.com/sotty, are you still working on this PR?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#27 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAf0Olz4-yQGhfH4n_jwRkNDcGFT18uFks5qS8bDgaJpZM4CfcnO
.

gastaldi · 2016-07-06T15:23:24Z

Awesome, thank you. Haven't fully checked yet, but it would be nice if it supported Lambdas too.

jamestyrrell · 2016-07-06T15:25:08Z

@sotty That is great to hear as I just started to get my hands dirty and hit a wall when VariableDeclarator.getInit() gives me back a String.

gastaldi · 2016-07-06T15:26:19Z

Perhaps this project may give some ideas: https://github.com/square/javapoet

prksean · 2018-02-12T21:37:08Z

@sotty Hi is there any update on this project? Thanks

kasium · 2019-01-26T16:07:01Z

@sotty I really love this idea. Do you think you are able to finish it in the next time or is there any update on this?

sotty · 2019-01-28T12:57:04Z

Unfortunately I do not have the bandwidth these days, but I may have time to get back to this project in late around mid May

…

On Sat, Jan 26, 2019 at 10:07 AM Kai Müller ***@***.***> wrote: @sotty <https://github.com/sotty> I really love this idea. Do you think you are able to finish it in the next time or is there any update on this? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#27 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAf0OgSmM5Pj4cpJ6dx29rNeh4WjiJHKks5vHH0ngaJpZM4CfcnO> .

sotty force-pushed the stats_exprs branch from 65829f9 to 02d49bf Compare September 8, 2014 04:16

gastaldi changed the title ~~Java Statement Fluent Model~~ ROASTER-1: Java Statement Fluent Model Sep 11, 2014

gastaldi force-pushed the master branch 2 times, most recently from 7badf29 to 70f87e1 Compare September 11, 2014 19:18

sotty force-pushed the stats_exprs branch from 02d49bf to 189fa1e Compare September 11, 2014 20:18

lincolnthree force-pushed the master branch 2 times, most recently from d9e5f2c to ff28cd6 Compare September 22, 2014 21:13

gastaldi force-pushed the master branch from b52d14d to c793863 Compare September 23, 2014 02:16

gastaldi force-pushed the master branch from 8d9d7e2 to 5392e54 Compare October 28, 2014 13:58

sotty force-pushed the stats_exprs branch 2 times, most recently from c5386ab to 5955b08 Compare December 30, 2014 15:41

sotty force-pushed the stats_exprs branch from 5955b08 to 1ef5040 Compare January 8, 2015 08:52

sotty force-pushed the stats_exprs branch 4 times, most recently from 72450f4 to 247be3b Compare July 26, 2015 02:49

gastaldi reviewed Jul 26, 2015
View reviewed changes

sotty force-pushed the stats_exprs branch from 247be3b to 517d98c Compare July 26, 2015 15:05

gastaldi reviewed Jul 27, 2015
View reviewed changes

gastaldi reviewed Jul 28, 2015
View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ROASTER-1: Java Statement Fluent Model #27

ROASTER-1: Java Statement Fluent Model #27

sotty commented Sep 8, 2014

gastaldi commented Sep 8, 2014

sotty commented Sep 8, 2014

gastaldi commented Nov 12, 2014

gastaldi commented Nov 12, 2014

agoncal commented Apr 17, 2015

sotty commented Apr 18, 2015

agoncal commented Apr 18, 2015

gastaldi Jul 26, 2015

sotty Jul 26, 2015

sotty commented Jul 26, 2015

gastaldi Jul 27, 2015

gastaldi commented Jul 27, 2015

gastaldi commented Jul 28, 2015

gastaldi Jul 28, 2015

sotty Jul 28, 2015

sotty commented Jul 28, 2015

sotty commented Jul 28, 2015

jamestyrrell commented Jul 5, 2016

forge-bot commented Jul 5, 2016

gastaldi commented Jul 6, 2016

sotty commented Jul 6, 2016

gastaldi commented Jul 6, 2016

jamestyrrell commented Jul 6, 2016

gastaldi commented Jul 6, 2016

prksean commented Feb 12, 2018

kasium commented Jan 26, 2019

sotty commented Jan 28, 2019 via email

ROASTER-1: Java Statement Fluent Model #27

Are you sure you want to change the base?

ROASTER-1: Java Statement Fluent Model #27

Conversation

sotty commented Sep 8, 2014

gastaldi commented Sep 8, 2014

sotty commented Sep 8, 2014

gastaldi commented Nov 12, 2014

gastaldi commented Nov 12, 2014

agoncal commented Apr 17, 2015

sotty commented Apr 18, 2015

agoncal commented Apr 18, 2015

gastaldi Jul 26, 2015

Choose a reason for hiding this comment

sotty Jul 26, 2015

Choose a reason for hiding this comment

sotty commented Jul 26, 2015

gastaldi Jul 27, 2015

Choose a reason for hiding this comment

gastaldi commented Jul 27, 2015

gastaldi commented Jul 28, 2015

gastaldi Jul 28, 2015

Choose a reason for hiding this comment

sotty Jul 28, 2015

Choose a reason for hiding this comment

sotty commented Jul 28, 2015

sotty commented Jul 28, 2015

jamestyrrell commented Jul 5, 2016

forge-bot commented Jul 5, 2016

gastaldi commented Jul 6, 2016

sotty commented Jul 6, 2016

gastaldi commented Jul 6, 2016

jamestyrrell commented Jul 6, 2016

gastaldi commented Jul 6, 2016

prksean commented Feb 12, 2018

kasium commented Jan 26, 2019

sotty commented Jan 28, 2019 via email