Skip to content

Commit

Permalink
remove some todos
Browse files Browse the repository at this point in the history
  • Loading branch information
Korijn committed Jan 8, 2024
1 parent 9d1f13b commit e1c2ef0
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions observ/object_proxy.py
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ def __setattr__(self, name, value):
# the set attr is not stateful (e.g. someone
# is attaching a bound method)
# so no need to track this modification
# TODO: we could cache this?
return retval

new_value = getattr(target, name, None)
Expand Down Expand Up @@ -87,8 +86,8 @@ def passthrough(method):
def trap(self, *args, **kwargs):
fn = getattr(self.__target__, method, None)
if fn is None:
# TODO: we could cache this
# but it is possible a class is dynamically modified later
# we don't cache this
# since it is possible a class is dynamically modified later
# invalidating the cached result...
raise TypeError(f"object of type '{type(self)}' has no {method}")
return fn(*args, **kwargs)
Expand Down

0 comments on commit e1c2ef0

Please sign in to comment.