adds type hints to public APIs #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ju1ius
force-pushed
the
ju1ius/typing
branch
from
14a87e3
to
8d0e8bf
Compare
Korijn
reviewed
Nov 14, 2023
Korijn
reviewed
Nov 14, 2023
|
|
||
| if isinstance(target, set): | ||
| return {to_raw(t) for t in target} | ||
| return cast(T, {to_raw(t) for t in target}) |
There was a problem hiding this comment.
are these casts in to_raw really necessary? return {} is already a plain dict right?
There was a problem hiding this comment.
@ju1ius can you share your thoughts on this one?
Korijn
reviewed
Nov 14, 2023
Korijn
reviewed
Nov 14, 2023
Korijn
requested changes
Nov 14, 2023
ju1ius
force-pushed
the
ju1ius/typing
branch
from
5d1322c
to
bbdd814
Compare
Slots are immutable so using lists is unnecessary.
ju1ius
force-pushed
the
ju1ius/typing
branch
from
bbdd814
to
0d1e8fe
Compare
|
Are you going to address the remaining comments? Otherwise I'd like to merge and move forward |
If it's OK for you then by all means do! 👍🏻 |
Korijn
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #110