fix: Add F1_ prefix to over-scoped LOG_LEVEL, LOG_FORMAT environment variables #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvloff-f3
previously approved these changes
Sep 10, 2024
…variables The change needed for back-compatibility with previous versions when LOG_LEVEL and LOG_FORMAT were not used to control f1 outputs. As these are quite common env variable names, they are currently over-scoped. F1 users might want to use custom loggers within their own scenarios that rely on such environment variables and configure them differently than f1 runner itself. LOG_FILE_PATH variable stays the same for back-compatibility.
dmitryabramov-f3
force-pushed
the
dabramov-fix-over-scoped-env-vars
branch
from
20f42c8 to
4ff2e87
Compare
nvloff-f3
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change is needed for back-compatibility with previous versions when
LOG_LEVELandLOG_FORMATwere not used to control f1 outputs (introduced here #260)As these are quite common env variable names, they are currently over-scoped. F1 users might want to use custom loggers within their own scenarios that rely on such environment variables and configure them differently than f1 runner itself.
LOG_FILE_PATHvariable stays the same for back-compatibility as it was present for a long time.