fix(metrics): fix race condition in metrics.Init() #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvloff-f3
force-pushed
the
nvloff-metrics-init-race
branch
from
c5571c9 to
df5d113
Compare
IterationMetricsEnabled can be concurrently set
```
==================
WARNING: DATA RACE
Write at 0x00c000124098 by goroutine 12:
github.com/form3tech-oss/f1/v2/internal/metrics.Init()
/Users/nikolayvladimirov/go/src/github.com/form3tech-oss/f1/internal/metrics/metrics.go:82 +0x7c
github.com/form3tech-oss/f1/v2/internal/metrics_test.TestMetrics_Init_IsSafe.func1()
/Users/nikolayvladimirov/go/src/github.com/form3tech-oss/f1/internal/metrics/metrics_test.go:15 +0x20
Previous write at 0x00c000124098 by goroutine 14:
github.com/form3tech-oss/f1/v2/internal/metrics.Init()
/Users/nikolayvladimirov/go/src/github.com/form3tech-oss/f1/internal/metrics/metrics.go:82 +0x7c
github.com/form3tech-oss/f1/v2/internal/metrics_test.TestMetrics_Init_IsSafe.func1()
/Users/nikolayvladimirov/go/src/github.com/form3tech-oss/f1/internal/metrics/metrics_test.go:15 +0x20
Goroutine 12 (running) created at:
github.com/form3tech-oss/f1/v2/internal/metrics_test.TestMetrics_Init_IsSafe()
/Users/nikolayvladimirov/go/src/github.com/form3tech-oss/f1/internal/metrics/metrics_test.go:14 +0xa4
testing.tRunner()
/opt/homebrew/Cellar/go/1.23.1/libexec/src/testing/testing.go:1690 +0x184
testing.(*T).Run.gowrap1()
/opt/homebrew/Cellar/go/1.23.1/libexec/src/testing/testing.go:1743 +0x40
Goroutine 14 (finished) created at:
github.com/form3tech-oss/f1/v2/internal/metrics_test.TestMetrics_Init_IsSafe()
/Users/nikolayvladimirov/go/src/github.com/form3tech-oss/f1/internal/metrics/metrics_test.go:14 +0xa4
testing.tRunner()
/opt/homebrew/Cellar/go/1.23.1/libexec/src/testing/testing.go:1690 +0x184
testing.(*T).Run.gowrap1()
/opt/homebrew/Cellar/go/1.23.1/libexec/src/testing/testing.go:1743 +0x40
```
nvloff-f3
force-pushed
the
nvloff-metrics-init-race
branch
from
df5d113 to
d2db6af
Compare
miketonks-form3
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IterationMetricsEnabled can be concurrently set