Injection of static label/values to the F1 metrics #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlornac
force-pushed
the
metrics_enrichments
branch
4 times, most recently
from
91675ae to
9e328ff
Compare
nvloff-f3
requested changes
Oct 10, 2024
There was a problem hiding this comment.
A few notes. Also:
Ideally we want to provide an API way(via opts similar to passing a custom logger) to adjust settings outside of env vars.
The way I think about f1 configuration is - the user should be able to set as much as possible via code where they can choose any source for that configuration. Where we provide a reasonable default configuration source via env vars.
mlornac
force-pushed
the
metrics_enrichments
branch
from
9e328ff to
78cee04
Compare
mlornac
changed the title
mlornac
force-pushed
the
metrics_enrichments
branch
8 times, most recently
from
19a2200 to
ee20fed
Compare
nvloff-f3
previously approved these changes
Oct 10, 2024
mlornac
force-pushed
the
metrics_enrichments
branch
2 times, most recently
from
18ca708 to
d29cd8e
Compare
mlornac
force-pushed
the
metrics_enrichments
branch
from
d29cd8e to
b4368ab
Compare
nvloff-f3
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Injecting labels with values into f1 metrics.
The labels are programmatically passed to the summary vecs