fix: race

formancehq · Jan 29, 2025 · 0da77e0 · 0da77e0
1 parent 8ed6d5d
commit 0da77e0
Show file tree

Hide file tree

Showing 17 changed files with 63 additions and 2 deletions.
diff --git a/internal/api/bulking/mocks_ledger_controller_test.go b/internal/api/bulking/mocks_ledger_controller_test.go
diff --git a/internal/api/common/mocks_ledger_controller_test.go b/internal/api/common/mocks_ledger_controller_test.go
diff --git a/internal/api/common/mocks_system_controller_test.go b/internal/api/common/mocks_system_controller_test.go
diff --git a/internal/api/v1/mocks_ledger_controller_test.go b/internal/api/v1/mocks_ledger_controller_test.go
diff --git a/internal/api/v1/mocks_system_controller_test.go b/internal/api/v1/mocks_system_controller_test.go
diff --git a/internal/api/v2/mocks_ledger_controller_test.go b/internal/api/v2/mocks_ledger_controller_test.go
diff --git a/internal/api/v2/mocks_system_controller_test.go b/internal/api/v2/mocks_system_controller_test.go
diff --git a/internal/controller/ledger/controller_generated_test.go b/internal/controller/ledger/controller_generated_test.go
diff --git a/internal/controller/ledger/controller_with_too_many_client_handling_generated_test.go b/internal/controller/ledger/controller_with_too_many_client_handling_generated_test.go
diff --git a/internal/controller/ledger/listener_generated_test.go b/internal/controller/ledger/listener_generated_test.go
diff --git a/internal/controller/ledger/numscript_parser_generated_test.go b/internal/controller/ledger/numscript_parser_generated_test.go
diff --git a/internal/controller/ledger/numscript_runtime_generated_test.go b/internal/controller/ledger/numscript_runtime_generated_test.go
diff --git a/internal/controller/ledger/store_generated_test.go b/internal/controller/ledger/store_generated_test.go
diff --git a/internal/leadership/context.go b/internal/leadership/context.go
@@ -2,6 +2,7 @@ package leadership
 
 import (
 	"context"
+	"sync"
 )
 
 type contextKey string
@@ -17,17 +18,26 @@ func IsLeader(ctx context.Context) bool {
 	if h == nil {
 		return false
 	}
-	return h.(*holder).isLeader
+	holder := h.(*holder)
+	holder.Lock()
+	defer holder.Unlock()
+
+	return holder.isLeader
 }
 
 func setIsLeader(ctx context.Context, isLeader bool) {
 	h := ctx.Value(holderContextKey)
 	if h == nil {
 		return
 	}
-	h.(*holder).isLeader = isLeader
+	holder := h.(*holder)
+	holder.Lock()
+	defer holder.Unlock()
+
+	holder.isLeader = isLeader
 }
 
 type holder struct {
+	sync.Mutex
 	isLeader bool
 }
diff --git a/internal/storage/driver/buckets_generated_test.go b/internal/storage/driver/buckets_generated_test.go
diff --git a/internal/storage/driver/ledger_generated_test.go b/internal/storage/driver/ledger_generated_test.go
diff --git a/internal/storage/driver/system_generated_test.go b/internal/storage/driver/system_generated_test.go