fix: migrations number drift #1226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Caution Review failedFailed to post review comments WalkthroughThis PR introduces comprehensive changes across multiple domains: adding idempotency-hit tracking to controller methods with HTTP header propagation, implementing a new exporter update API, refactoring Pulumi image configuration, updating storage queries with scoped selects, modifying transaction query parameters (timestamp instead of date), adding balance filter support for big integers, updating mock generation with -typed flag, and expanding test coverage for new features. Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant Handler as V2 Handler
participant Controller as Ledger Controller
participant Store as Storage Layer
participant Processor as Log Processor
Client->>Handler: CreateTransaction Request<br/>(with Idempotency-Key)
Handler->>Controller: CreateTransaction(ctx, params)
Controller->>Processor: forgeLog(ctx, store, params, fn)
alt Idempotency Key Found
Processor->>Store: GetLogByIdempotencyKey(key)
Store-->>Processor: (log, output, nil)
Processor-->>Controller: (log, output, true, nil)
else First Request
Processor->>Processor: Execute transaction processing
Processor->>Store: PersistLog(...)
Store-->>Processor: (success)
Processor-->>Controller: (log, output, false, nil)
end
Controller->>Handler: Return (log, output, idempotencyHit, error)
alt idempotencyHit == true
Handler->>Handler: Set Header "Idempotency-Hit: true"
else idempotencyHit == false
Handler->>Handler: (No Idempotency-Hit header)
end
Handler-->>Client: Response with Headers
sequenceDiagram
participant Admin
participant API as V2 UpdateExporter Endpoint
participant Manager as Replication Manager
participant Storage
participant Pipeline
participant Driver
Admin->>API: PUT /exporters/{id} (new config)
API->>Manager: UpdateExporter(ctx, id, config)
Manager->>Manager: ValidateDriver(config.Driver)
alt Invalid Driver
Manager-->>API: ErrInvalidDriverConfiguration
API-->>Admin: 400 Bad Request
else Not Found
Manager-->>API: ErrExporterNotFound
API-->>Admin: 404 Not Found
else Valid
Manager->>Manager: stopExporter(id)
Manager->>Pipeline: Stop pipelines using exporter
Pipeline->>Driver: Stop()
Manager->>Storage: UpdateExporter(exporter)
Storage-->>Manager: Success
Manager->>Manager: synchronizePipelines()
Manager-->>API: nil
API-->>Admin: 204 No Content
end
Estimated code review effort🎯 5 (Critical) | ⏱️ ~120 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
flemzord
approved these changes
Jan 5, 2026
flemzord
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.