Several ntlmrelayx SMBv1 server fixes#2129
Open
rtpt-romankarwacik wants to merge 3 commits intofortra:masterfrom
Open
Several ntlmrelayx SMBv1 server fixes#2129rtpt-romankarwacik wants to merge 3 commits intofortra:masterfrom
rtpt-romankarwacik wants to merge 3 commits intofortra:masterfrom
Conversation
anadrianmanrique
added
the
in review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relayToHostwas sometimes not properly set, so I changed it to how it is done in the other smbrelayservers.The infinite loop seems like a copy paste error.
The
NativeOS/NativeLanManrelated changes caused a MacOS Samba Server to not respond and Wireshark marks the packet also as malformed, but I did not look forther into this, so this could also be ignored from the commits.