Add AD-Legacy zone fallback for --add-dns-record#2140
Open
Q2Flc2FySec wants to merge 1 commit intofortra:masterfrom
Open
Add AD-Legacy zone fallback for --add-dns-record#2140Q2Flc2FySec wants to merge 1 commit intofortra:masterfrom
--add-dns-record#2140Q2Flc2FySec wants to merge 1 commit intofortra:masterfrom
Conversation
Signed-off-by: Thomas Caesar <thomas.caesar@sva.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
--add-dns-recordonly attempts to create DNS records in the AD-Domain partition (DomainDnsZones). This fails on environments where DNS is stored in the AD-Legacy partition (CN=MicrosoftDNS,CN=System).This PR adds a fallback mechanism: if creating a record in the AD-Domain partition fails, it automatically retries against the AD-Legacy partition. The duplicate-check and subsequent NS record creation (for
wpad) are also aware of both partitions to ensure consistency.Changes:
dns_base_dn_legacyalongside the existingdns_base_dnactive_dns_base_dn) so the NS record is placed in the same location