-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add iterators #4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to dc57679 in 1 minute and 0 seconds
More details
- Looked at
177
lines of code in4
files - Skipped
0
files when reviewing. - Skipped posting
0
drafted comments based on config settings.
Workflow ID: wflow_NpQRdI0fAY3VA8UB
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Incremental review on bf7ffd8 in 21 seconds
More details
- Looked at
17
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
0
drafted comments based on config settings.
Workflow ID: wflow_i0eZfwB0oHKXPqFs
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
@@ -12,12 +12,6 @@ on: | |||
|
|||
pull_request: | |||
branches: [ "main" ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider re-adding the 'paths' specification to limit workflow runs to relevant changes, preventing unnecessary executions.
Important
Add
Iter
struct and implementIterator
trait forShardMap
to support iteration over key-value pairs.Iter
struct insrc/iter.rs
to iterate overShardMap
key-value pairs.Iterator
trait forIter
to support iteration.iter()
method toShardMap
insrc/shard_map.rs
to return anIter
instance.test_iter
andtest_iter_empty
insrc/iter.rs
to verify iterator functionality.read_sync()
andwrite_sync()
methods toShard
insrc/shard.rs
for synchronous access..github/workflows/rust.yml
for pull requests.This description was created by for bf7ffd8. It will automatically update as commits are pushed.