refactor: bump hashbrown to v0.15.0, use HashTable api

[willothy]

I had previously thought that the older raw API was more performant, but after some additional testing the new API appears to work well. It allows me to remove some unsafe code, so updating seems like a win-win.

---

Important

Refactor to use hashbrown v0.15.0 HashTable API, removing unsafe code in shard.rs and shard_map.rs.

• Dependencies:
  • Bump hashbrown to version 0.15.0 in Cargo.toml and Cargo.lock.
  • Add dependencies allocator-api2, equivalent, and foldhash in Cargo.lock.
• Refactor:
  • Replace hashbrown::raw::RawTable with hashbrown::HashTable in shard.rs.
  • Use hashbrown::hash_table::Entry API in shard_map.rs for insert, get, get_mut, and remove functions.
  • Remove hash_u64() function in shard_map.rs and replace with hash_one() method.
• Safety:
  • Remove unsafe code related to raw table operations in shard_map.rs.

^{This description was created by for bcc542b. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to bcc542b in 22 seconds

More details

• Looked at 193 lines of code in 4 files
• Skipped 0 files when reviewing.
• Skipped posting 5 drafted comments based on config settings.

1. src/shard_map.rs:182

• Draft comment:
  Ensure hash_one is used correctly and consistently across the codebase. It replaces the previous custom hash function.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The hash_one method is used multiple times in the code. It is a new method introduced in the updated hashbrown version. Ensure that it is used correctly and consistently across the codebase.

2. src/shard_map.rs:209

• Draft comment:
  Ensure the logic using entry is correctly adapted from the previous find_or_find_insert_slot method.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The entry method is used to replace the previous find_or_find_insert_slot method. Ensure that the logic is correctly adapted to the new API.

3. src/shard_map.rs:251

• Draft comment:
  Ensure the logic using find is correctly adapted from the previous get method.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The find method is used to replace the previous get method. Ensure that the logic is correctly adapted to the new API.

4. src/shard_map.rs:289

• Draft comment:
  Ensure the logic using find_mut is correctly adapted from the previous get_mut method.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The find_mut method is used to replace the previous get_mut method. Ensure that the logic is correctly adapted to the new API.

5. src/shard_map.rs:352

• Draft comment:
  Ensure the logic using find_entry is correctly adapted from the previous remove_entry method.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The find_entry method is used to replace the previous remove_entry method. Ensure that the logic is correctly adapted to the new API.

Workflow ID: wflow_HsBOW7JR0hVbqctg

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.