-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #472 #474 #476 Add News search in Baidu, Parsijoo & Mojeek #486
Conversation
Codecov Report
@@ Coverage Diff @@
## master #486 +/- ##
==========================================
- Coverage 84.45% 82.39% -2.07%
==========================================
Files 29 29
Lines 849 937 +88
==========================================
+ Hits 717 772 +55
- Misses 132 165 +33
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work again 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! 💯
@rohitsainicool @shankybora Please don't review without contributing and knowing about a project . You are welcome to contribute to FOSSASIA 👍 |
Approval by a maintainer hence merging. |
Please dont merge your own PRs. |
@mariobehling I and @vaibhavsingh97 have already asked him many times to follow best practices. We cannot rely on reviewers that are actually not contributing to project and @rohitsainicool & @shankybora are even new to Github. |
Okay @mariobehling @ParthS007 |
Fixes #472
Fixes #474
Fixes #476
Addresses #468
Checklist
master
branch.Changes proposed in this pull request:
Providing Heroku deployment at https://young-dusk-37307.herokuapp.com/
@shankybora @rohitsainicool @gabru-md Please review. Thanks !!