feat(cheats): RLP #11232
feat(cheats): RLP #11232
Conversation
qiweiii
requested review from
DaniPopes,
klkvr,
mattsse and
grandizzy
as code owners
| /// RLP encodes a list of bytes into an RLP payload. | ||
| #[cheatcode(group = Utilities)] | ||
| function toRlp(bytes[] calldata data) external pure returns (bytes memory); | ||
| /// RLP decodes an RLP payload into a list of bytes. | ||
| #[cheatcode(group = Utilities)] | ||
| function fromRlp(bytes calldata rlp) external pure returns (bytes[] memory data); |
There was a problem hiding this comment.
unsure how useful this really is because this can only bytes
but imo these dont really hurt
any opinions here @grandizzy
There was a problem hiding this comment.
I think is good for a start and then we could improve, @qiweiii wonder though why it is marked as breaking change?
There was a problem hiding this comment.
you mean in pr checklist? It should not, I just removed it
There was a problem hiding this comment.
@mattsse @grandizzy This is perfect for now, can just abi encode/decode each element which can be abstracted away by helper methods.
| import "ds-test/test.sol"; | ||
| import "cheats/Vm.sol"; | ||
|
|
||
| contract Rlp is DSTest { |
There was a problem hiding this comment.
Would like to see the following test:
- Use
cast block <some_block> --rawto get the raw rlp encoded block header for some given block. - Set the value above as a test constant (e.g.
bytes header = hex"...";) - Use
cast block <some_block> --jsonto get the blocks decoded fields. - Compare decoded RLP encoded block header to known hardcoded field values from previous step.
NOTES:
|
@qiweiii would oyu have time to drive this to the finish line? if not we can take it over, thank you |
|
sry pls take it, since I won't have time until next week |
Motivation
closes #11144
Add rlp related cheats as requested in the issue
PR Checklist