fix(anvil): log's removed field always false during reorg #11298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add ReorgedBlockNotification system for proper reorg handling - Collect block data before unwinding storage during rollbacks - Update LogsSubscription to emit logs with removed=true for reorged blocks - Add comprehensive test using SimpleStorage contract Fixes foundry-rs#9933
Peponks9
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy,
yash-atreya and
zerosnacks
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #9933
During blockchain reorgs, event logs from removed blocks should be re-emitted with
removed: trueto notify subscribers that those logs are no longer valid. However, they were always emitted withremoved: false, making it impossible for clients to properly handle reorgs.Solution
ReorgedBlockNotificationsystem alongside existingNewBlockNotificationrollback()to collect block data and receipts before unwinding storageLogsSubscriptionto listen for reorg notifications and emit logs withremoved: truefilter_logsfunction to accept aremovedparameterPR Checklist
test_reorg_logs_removed_fieldusingSimpleStoragecontractcargocommands atCONTRIBUTING.md