perf(anvil): optimize internal data passing in log queries #11896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvekkk
requested review from
DaniPopes,
mattsse,
grandizzy,
yash-atreya,
zerosnacks,
onbjerg and
0xrusowsky
as code owners
onbjerg
requested changes
Oct 1, 2025
| && let Some(block) = storage.blocks.get(&block_hash).cloned() | ||
| { | ||
| drop(storage); | ||
| all_logs.extend(self.mined_logs_for_block(filter.clone(), block, block_hash)); |
There was a problem hiding this comment.
idt this change makes sense, using get_block is fine, what is the reasoning?
There was a problem hiding this comment.
The change avoids redundant hash_slow() calls. get_block(number) internally does hashes.get(&number) + blocks.get(&hash) but discards the hash, forcing mined_logs_for_block to recompute it via expensive RLP encoding + Keccak256.
|
|
||
| /// Returns all `Log`s mined by the node that were emitted in the `block` and match the `Filter` | ||
| fn mined_logs_for_block(&self, filter: Filter, block: Block) -> Vec<Log> { | ||
| fn mined_logs_for_block(&self, filter: Filter, block: Block, block_hash: B256) -> Vec<Log> { |
onbjerg
approved these changes
Oct 2, 2025
DaniPopes
approved these changes
Oct 2, 2025
silvekkk
added a commit
to silvekkk/foundry
that referenced
this pull request
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves performance of log query operations by optimizing how data is passed between internal functions. Refactoring reduces redundant operations by passing additional context that's already available at call sites, resulting in measurable performance improvements particularly for range queries.
Internal optimization only.