refactor(cheatcodes): simplify broadcastable tx creation#13982
Open
mablr wants to merge 1 commit intofoundry-rs:masterfrom
Open
refactor(cheatcodes): simplify broadcastable tx creation#13982mablr wants to merge 1 commit intofoundry-rs:masterfrom
mablr wants to merge 1 commit intofoundry-rs:masterfrom
Conversation
- Remove TransactionMaybeSigned::new_signed() helper in favor of direct struct construction to avoid double signer recovery - Use TxEnvelope instead of FoundryTxEnvelope in executeTransaction cheatcode as it will become generic soon, allowing to remove Tempo/OP rejection checks.
mablr
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse,
onbjerg and
zerosnacks
as code owners
stevencartavia
approved these changes
Mar 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Towards
Cheatcodesgenerics:Remove
TransactionMaybeSigned::new_signed()helper in favor of direct struct construction to avoid double signer recoveryUse
TxEnvelopeinstead ofFoundryTxEnvelopeinexecuteTransactionCallcheatcode as it will become generic soon, allowing to remove Tempo/OP rejection checks (actually aligns onbroadcastRawTransactionCallimpl).