lint: add post-increment-decrement gas lint#13986
Open
ParthSinghPS wants to merge 1 commit intofoundry-rs:masterfrom
Open
lint: add post-increment-decrement gas lint#13986ParthSinghPS wants to merge 1 commit intofoundry-rs:masterfrom
ParthSinghPS wants to merge 1 commit intofoundry-rs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds a new
post-increment-decrementlint rule in thegascategory that flagsi++andi--when used in for loop update expressions, suggesting++iand--iinstead.Why
Post-increment (
i++) and post-decrement (i--) return the value beforemodification, requiring an extra copy operation under the hood. In for loop
update expressions the return value is always discarded, so the copy is
pure overhead. Pre-increment (
++i) skips the copy entirely.The lint is intentionally scoped to for loop update expressions only. Outside
of loops,
i++vs++iis a semantic choice the developer may have madedeliberately.
Changes
crates/lint/src/sol/gas/increment.rs: newEarlyLintPassimplementationcrates/lint/src/sol/gas/mod.rs: registered the new lintcrates/lint/testdata/PostIncrementDecrement.sol: test cases coveringtriggering and non-triggering patterns
crates/lint/testdata/PostIncrementDecrement.stderr: blessed test output