Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify which tokens to prefund the account with #2247

Closed
Arcticae opened this issue Jun 21, 2024 · 0 comments · Fixed by #2328
Closed

Specify which tokens to prefund the account with #2247

Arcticae opened this issue Jun 21, 2024 · 0 comments · Fixed by #2328
Assignees
@integraledelebesgue
Labels
documentation Improvements or additions to documentation new sncast
Milestone
Cast UX improvements

Comments

@Arcticae
Copy link
Contributor

Which components does the task require to be changed? (think hard pls)

sncast

Description

It is not said which token you need to prefund with, when deploying an account from cast.
This should be fixed in order to address transactions v3 as well.

This is a documentation issue mainly, but we do display instruction in the CLI as well, we should update that.
@Arcticae Arcticae added documentation Improvements or additions to documentation sncast labels Jun 21, 2024
@Arcticae Arcticae added this to the Cast UX improvements milestone Jun 21, 2024
@github-actions github-actions bot added the new label Jun 21, 2024
@integraledelebesgue integraledelebesgue linked a pull request Jul 22, 2024 that will close this issue
Added the expected prefund token type to account create output #2328
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Jul 29, 2024
@integraledelebesgue
Added the expected prefund token type to account create output (#2328)
81ddfc3 
Closes
[#2247](https://github.com/orgs/foundry-rs/projects/3/views/3?filterQuery=&pane=issue&itemId=68288252)

## Introduced changes
- `account create` now outputs information about the expected type of
tokens needed to prefund a newly created account with
- documentation explains it too

## Checklist
- [x] Linked relevant issue
- [x] Updated relevant documentation
- [x] Added relevant tests
- [x] Performed self-review of the code
- [x] Added changes to `CHANGELOG.md`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@integraledelebesgue integraledelebesgue

Labels
documentation Improvements or additions to documentation new sncast
Projects
Starknet foundry
Archived in project
Milestone
Cast UX improvements
Development

Successfully merging a pull request may close this issue.

Added the expected prefund token type to account create output foundry-rs/starknet-foundry
2 participants
@Arcticae @integraledelebesgue